remote: fix Connect, returned nil error on failure. (#167)

Author: smola

remote.go

@@ -51,7 +51,7 @@ func (r *Remote) Connect() error {
 	var err error
 	r.fetchSession, err = r.client.NewFetchPackSession(r.endpoint)
 	if err != nil {
-		return nil
+		return err
 	}
 
 	return r.retrieveAdvertisedReferences()

remote_test.go

@@ -44,6 +44,13 @@ func (s *RemoteSuite) TestnewRemoteInvalidEndpoint(c *C) {
 	c.Assert(err, NotNil)
 }
 
+func (s *RemoteSuite) TestnewRemoteNonExistentEndpoint(c *C) {
+	r := newRemote(nil, nil, &config.RemoteConfig{Name: "foo", URL: "ssh://non-existent/foo.git"})
+
+	err := r.Connect()
+	c.Assert(err, NotNil)
+}
+
 func (s *RemoteSuite) TestnewRemoteInvalidSchemaEndpoint(c *C) {
 	r := newRemote(nil, nil, &config.RemoteConfig{Name: "foo", URL: "qux://foo"})