Perf: Traverse commit history instead of reading the packfile #698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajnavarro
force-pushed
the
perf/list-only-reachable-objects
branch
4 times, most recently
from
301f3ca to
fd8ac0b
Compare
kuba--
approved these changes
Feb 14, 2019
| i.iter, err = i.repo.CommitObjects() | ||
| i.iter, err = | ||
| i.repo.Log(&git.LogOptions{ | ||
| All: true, |
There was a problem hiding this comment.
Maybe we should force order by time (WDYT)?
By default pre-order will be used, which I think works slightly different than native git implementation.
There was a problem hiding this comment.
but here we don't want to mimic 100% git log output, we want to reduce unnecessary disk reads. Ordering commits will not give us any performance improvement.
erizocosmico
approved these changes
Feb 14, 2019
Signed-off-by: Antonio Jesus Navarro Perez <[email protected]>
To avoid show orphan commits and improve performance on commits table, instead of read all the objects from each repository and discard commits, we can execute from go-git a git log --all command and traverse commit history, avoiding read a lot of data from disk. Signed-off-by: Antonio Jesus Navarro Perez <[email protected]>
ajnavarro
force-pushed
the
perf/list-only-reachable-objects
branch
from
fd8ac0b to
9748ee3
Compare
|
@kuba-- @erizocosmico tests finally passing |
kuba--
approved these changes
Feb 15, 2019
|
Some numbers using gitbase-regression with complexity=2: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid show orphan commits and improve performance on commits table, instead of reading all the objects from each repository and discard commits, we can execute from go-git a git log --all command and traverse commit history, avoiding read a lot of data from disk.
It closes #617