Skip to content

Commit f4b1f97

Browse files
committed
Fixed execution of RxJS teardown logic on complete (7.2.3 regression)
1 parent 281fa3a commit f4b1f97

File tree

22 files changed

+88
-55
lines changed

22 files changed

+88
-55
lines changed

material/assets/javascripts/bundle.9264e2c0.min.js

Lines changed: 29 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

material/assets/javascripts/bundle.febc23d1.min.js.map renamed to material/assets/javascripts/bundle.9264e2c0.min.js.map

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

material/assets/javascripts/bundle.febc23d1.min.js

Lines changed: 0 additions & 29 deletions
This file was deleted.

material/base.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,7 @@ <h1>{{ page.title | d(config.site_name, true)}}</h1>
223223
</script>
224224
{% endblock %}
225225
{% block scripts %}
226-
<script src="{{ 'assets/javascripts/bundle.febc23d1.min.js' | url }}"></script>
226+
<script src="{{ 'assets/javascripts/bundle.9264e2c0.min.js' | url }}"></script>
227227
{% for path in config["extra_javascript"] %}
228228
<script src="{{ path | url }}"></script>
229229
{% endfor %}

material/overrides/assets/javascripts/bundle.515b7185.min.js renamed to material/overrides/assets/javascripts/bundle.a07ad7e8.min.js

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

material/overrides/assets/javascripts/bundle.515b7185.min.js.map renamed to material/overrides/assets/javascripts/bundle.a07ad7e8.min.js.map

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

material/overrides/main.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,5 +16,5 @@
1616
{% endblock %}
1717
{% block scripts %}
1818
{{ super() }}
19-
<script src="{{ 'overrides/assets/javascripts/bundle.515b7185.min.js' | url }}"></script>
19+
<script src="{{ 'overrides/assets/javascripts/bundle.a07ad7e8.min.js' | url }}"></script>
2020
{% endblock %}

src/assets/javascripts/components/content/code/index.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ import {
3131
} from "rxjs"
3232
import {
3333
distinctUntilKeyChanged,
34+
finalize,
3435
map,
3536
switchMap,
3637
tap,
@@ -175,7 +176,8 @@ export function mountCodeBlock(
175176
/* Create and return component */
176177
return watchCodeBlock(el, options)
177178
.pipe(
178-
tap(internal$),
179+
tap(state => internal$.next(state)),
180+
finalize(() => internal$.complete()),
179181
map(state => ({ ref: el, ...state }))
180182
)
181183
}

src/assets/javascripts/components/content/details/index.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
import { Observable, Subject } from "rxjs"
2424
import {
2525
filter,
26+
finalize,
2627
map,
2728
mapTo,
2829
mergeWith,
@@ -107,7 +108,8 @@ export function mountDetails(
107108
/* Create and return component */
108109
return watchDetails(el, options)
109110
.pipe(
110-
tap(internal$),
111+
tap(state => internal$.next(state)),
112+
finalize(() => internal$.complete()),
111113
mapTo({ ref: el })
112114
)
113115
}

src/assets/javascripts/components/dialog/index.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ import {
2828
of
2929
} from "rxjs"
3030
import {
31+
finalize,
3132
delay,
3233
map,
3334
observeOn,
@@ -131,7 +132,8 @@ export function mountDialog(
131132
/* Create and return component */
132133
return watchDialog(el, options)
133134
.pipe(
134-
tap(internal$),
135+
tap(state => internal$.next(state)),
136+
finalize(() => internal$.complete()),
135137
map(state => ({ ref: el, ...state }))
136138
)
137139
}

0 commit comments

Comments
 (0)