Fix Conflate Stale Rendering Logic for Short Circuit #1263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steve-the-edwards
force-pushed
the
sedwards/fix-conflate
branch
from
6466578 to
75d31c7
Compare
steve-the-edwards
requested review from
zach-klippenstein and
a team
as code owners
Short circuit if there is no changed state while conflating.
steve-the-edwards
force-pushed
the
sedwards/fix-conflate
branch
from
75d31c7 to
ce54070
Compare
steve-the-edwards
changed the base branch from
main
to
sedwards/fix-output-tests
rjrjr
approved these changes
Feb 20, 2025
workflow-runtime/src/commonTest/kotlin/com/squareup/workflow1/RenderWorkflowInTest.kt
Show resolved
Hide resolved
zach-klippenstein
approved these changes
Feb 21, 2025
| */ | ||
| suspend fun shortCircuitForUnchangedState(actionResult: ActionProcessingResult): Boolean { | ||
| if (runtimeConfig.contains(RENDER_ONLY_WHEN_STATE_CHANGES) && | ||
| fun shouldShortCircuitForUnchangedState(actionResult: ActionProcessingResult): Boolean { |
There was a problem hiding this comment.
new tongue-twister just dropped
| @@ -183,34 +176,40 @@ public fun <PropsT, OutputT, RenderingT> renderWorkflowIn( | |||
| // launched. | |||
| var actionResult: ActionProcessingResult = runner.processAction() | |||
|
|
|||
| if (shortCircuitForUnchangedState(actionResult)) continue | |||
| if (shouldShortCircuitForUnchangedState(actionResult)) { | |||
There was a problem hiding this comment.
This is much better.
…RenderWorkflowInTest.kt Co-authored-by: Ray Ryan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we kept rendering for
CONFLATE_STALE_RENDERINGSwe were not also checking if we should short circuit. We need to do both.If any of the actions applied produces output from the root runtime though, then we will stop applying actions, update the rendering, and then send the output.