Skip to content

Daniel/450 readonly disabled for textarea #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

djyotta
Copy link
Contributor

@djyotta djyotta commented Jun 24, 2024

Closes #450

Tested with this:

SELECT 'form' AS component, 'post' AS method;
SELECT 'select' AS type
, json('[
  { "label": "a", "value": "a", "selected": true },
  { "label": "b", "value": "b", "selected": false },
  { "label": "c", "value": "b", "selected": true },
]') AS options
, TRUE AS multiple
, TRUE AS dropdown
, TRUE AS readonly
, 's' AS name
;
SELECT 'textarea' AS type
, 'abc' AS value
, 'ta' AS name
, TRUE AS readonly
;
  • disabled works fine for textarea and select and dropdown select
  • readonly works fine for textarea but not for dropdown select, so I removed implementation of readonly on select altogether

Copy link
Collaborator

@lovasoa lovasoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution !

@lovasoa lovasoa merged commit 7f8753e into sqlpage:main Jun 26, 2024
9 checks passed
@djyotta
Copy link
Contributor Author

djyotta commented Jun 27, 2024

No problem. I really needed this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

readonly and disabled are not applied to text area form elements
2 participants