Skip to content

Replace deprecated logging.warn with logging.warning #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2022

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Jun 22, 2022

Replace logging.warn (deprecated in Python 2.7, 2011) with logging.warning (added in Python 2.3, 2003).


  • Stay on point and keep it small so it can be easily reviewed. For example, try to apply any general refactoring separately outside of the PR.
  • Consider adding unit tests, especially for bug fixes. If you don't, tell us why.

Replacing deprecated function with one which has been around since 2.3.

  • All new and existing tests pass, with 100% test coverage (make test-coverage)
  • Linting passes (make lint)
  • Consider updating documentation. If you don't, tell us why.

Not big enough for docs.

  • List the environments / platforms in which you tested your changes.

macOS / Python 3.10

Thanks for contributing to this project!

Copy link
Collaborator

@thibaudcolas thibaudcolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, TIL! Thank you for picking this up. I’m really surprised this hasn’t been flagged by python -X dev -W error example.py even though it clearly seems to be deprecated.

@thibaudcolas thibaudcolas merged commit ee13fa7 into springload:main Jul 5, 2022
@thibaudcolas thibaudcolas added the enhancement New feature or request label Jul 5, 2022
@thibaudcolas thibaudcolas added this to the Nice to have milestone Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants