Skip to content

Introduce separate HttpComponents5MessageSender that provides the client with no further configuration #1519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
snicoll opened this issue Apr 8, 2025 · 0 comments
Closed

Introduce separate HttpComponents5MessageSender that provides the client with no further configuration #1519

snicoll opened this issue Apr 8, 2025 · 0 comments
Assignees
@snicoll
Labels
type: enhancement A general enhancement
Milestone
4.1.0-RC1

Comments

@snicoll
Copy link
Member

snicoll commented Apr 8, 2025

As discussed in #1035 (comment), HttpComponents5MessageSender is confusing as it allows both an HttpClient to be set or one to be configured. This makes an awkward state where calling configuration methods once a client is provided throws an exception.
@snicoll snicoll added the type: enhancement A general enhancement label Apr 8, 2025
@snicoll snicoll added this to the 4.1.0-RC1 milestone Apr 8, 2025
@snicoll snicoll self-assigned this Apr 8, 2025
@snicoll snicoll closed this as completed in f250abb Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snicoll snicoll

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
4.1.0-RC1
Development

No branches or pull requests
1 participant
@snicoll