Improve JDBC integration tests #624
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpavic
force-pushed
the
improve-jdbc-it
branch
from
ba9d40b to
3a1166e
Compare
|
Thanks for the PR! This is merged via 34948d6 |
rwinch
added
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be useful to improve JDBC integration tests to cover multiple RDBMS vendors. This will be particularly useful once #613 is merged, since it introduces multiple configuration paths which results in different SQL statement used for some vendors.
This PR parameterizes
JdbcOperationsSessionRepositoryITeststo run on all embedded database types supported by Spring'sEmbeddedDatabaseBuilder.