Skip to content

Verify session existence before update in ReactiveRedisOperationsSessionRepository #1185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vpavic opened this issue Sep 9, 2018 · 0 comments
Closed

Verify session existence before update in ReactiveRedisOperationsSessionRepository #1185

vpavic opened this issue Sep 9, 2018 · 0 comments
Assignees
@vpavic
Labels
in: redis type: backport An issue that is a backport of another issue to a maintenance branch type: bug A general bug
Milestone
2.0.6

Comments

@vpavic
Copy link
Contributor

vpavic commented Sep 9, 2018

Backport of #1111.
@vpavic vpavic added type: bug A general bug Data Store in: redis type: backport An issue that is a backport of another issue to a maintenance branch labels Sep 9, 2018
@vpavic vpavic added this to the 2.0.6 milestone Sep 9, 2018
@vpavic vpavic self-assigned this Sep 9, 2018
vpavic added a commit that referenced this issue Sep 9, 2018
@vpavic
Verify session existence before update in ReactiveRedisOperationsSess…
7e8f500 
…ionRepository

Currently, ReactiveRedisOperationsSessionRepository#save does not ensure session's existence before executing update. This can result in an invalid session record in Redis, since write use only delta, and in turn to error while retrieving the invalid session record.

This commit adds check for session existence if session is being updated.

Closes gh-1185
@vpavic vpavic closed this as completed Sep 9, 2018
@vpavic vpavic mentioned this issue Sep 9, 2018
Closed
vpavic added a commit that referenced this issue Sep 10, 2018
@vpavic
Polish
ff10709 
See gh-1185
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vpavic vpavic

Labels
in: redis type: backport An issue that is a backport of another issue to a maintenance branch type: bug A general bug
Projects
None yet
Milestone
2.0.6
Development

No branches or pull requests
1 participant
@vpavic