Drop the aopalliance:aopalliance dependency
#4431
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Stephan202 Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
^ When I visit the CLA page I'm greeted with an "Internal Server Error". Will try again later. |
|
@Stephan202 Thank you for signing the Contributor License Agreement! |
As of Spring 4.3 RC1 the `org.aopalliance` interfaces are once again bundled with `spring-aop` [1]. Moreover, all modules with a dependency on `aopalliance:aopalliance` directly or indirectly also depend on `spring-aop`. This change drops the `aopalliance:aopalliance` dependency in all places it's declared. Where applicable an explicit dependency on `spring-aop` was added in its place. (This dependency was already present in most places; in one case the module didn't require `aopalliance:aopalliance` in the first place.) The documentation is updated accordingly. [1] https://jira.spring.io/browse/SPR-13984
The `aopalliance:aopalliance:1.0` dependency is indirectly pulled in by `spring-security-openid` through its dependence on `com.google.inject:guice:3.0`. There are no other references to ``aopalliance:aopalliance`.
|
I have rebased the branch and added one commit. Since this PR was filed a few months ago: can one of the maintainers perhaps have a look at it? |
rwinch
added
in: build
|
Thanks for the PR @Stephan202! This is merged into master via 9e719bc and 496ea3e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Spring 4.3 RC1 the
org.aopallianceinterfaces are once again bundledwith
spring-aop[1]. Moreover, all modules with a dependency onaopalliance:aopalliancedirectly or indirectly also depend onspring-aop.This change drops the
aopalliance:aopalliancedependency in all places it'sdeclared. Where applicable an explicit dependency on
spring-aopwas added inits place. (This dependency was already present in most places; in one case the
module didn't require
aopalliance:aopalliancein the first place.)The documentation is updated accordingly.
[1] https://jira.spring.io/browse/SPR-13984