Skip to content

Missing support for urn:ietf:params:oauth:grant-type:jwt-bearer in ClientRegistrations #9828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ThomasKasene opened this issue May 27, 2021 · 0 comments · Fixed by #9922
Closed

Missing support for urn:ietf:params:oauth:grant-type:jwt-bearer in ClientRegistrations #9828

ThomasKasene opened this issue May 27, 2021 · 0 comments · Fixed by #9922
Assignees
@sjohnr
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Milestone
5.6.0-M1

Comments

@ThomasKasene
Copy link
Contributor

ThomasKasene commented May 27, 2021 •
edited
Loading

Describe the bug
It would appear ClientRegistrations.withProviderConfiguration does not yet support urn:ietf:params:oauth:grant-type:jwt-bearer:

if (grantTypes != null && !grantTypes.contains(GrantType.AUTHORIZATION_CODE)) {
	throw new IllegalArgumentException(
			"Only AuthorizationGrantType.AUTHORIZATION_CODE is supported. The issuer \"" + issuer
					+ "\" returned a configuration of " + grantTypes);
}

Related to gh-9780
@ThomasKasene ThomasKasene added status: waiting-for-triage An issue we've not yet triaged type: bug A general bug labels May 27, 2021
@marcusdacoregio marcusdacoregio added in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) and removed status: waiting-for-triage An issue we've not yet triaged labels May 28, 2021
@jgrandja jgrandja added this to the 5.5.1 milestone May 28, 2021
@jgrandja jgrandja assigned sjohnr and unassigned jgrandja May 28, 2021
@sjohnr sjohnr mentioned this issue Jun 15, 2021
Merged
sjohnr pushed a commit to sjohnr/spring-security that referenced this issue Jun 15, 2021
Remove validation for unsupported grant types
9ad018f 
Closes spring-projectsgh-9828
sjohnr pushed a commit that referenced this issue Jun 16, 2021
@sjohnr
Remove validation for unsupported grant types
9b05afd 
Closes gh-9828
@sjohnr sjohnr modified the milestones: 5.5.1, 5.6.0-M1 Jun 16, 2021
@spring-projects-issues spring-projects-issues added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-5.5.x labels Jun 16, 2021
Closed
sjohnr pushed a commit that referenced this issue Jun 16, 2021
Remove validation for unsupported grant types
839cc5e 
Closes gh-9828
akohli96 pushed a commit to akohli96/spring-security that referenced this issue Aug 25, 2021
Remove validation for unsupported grant types
1544191 
Closes spring-projectsgh-9828
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjohnr sjohnr

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Projects
None yet
Milestone
5.6.0-M1
Development

Successfully merging a pull request may close this issue.

Remove validation for unsupported grant types sjohnr/spring-security
5 participants
@sjohnr @ThomasKasene @jgrandja @marcusdacoregio @spring-projects-issues