Skip to content

Split up NimbusOAuth2UserService #4447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rwinch opened this issue Jul 10, 2017 · 0 comments
Closed

Split up NimbusOAuth2UserService #4447

rwinch opened this issue Jul 10, 2017 · 0 comments
Assignees
@jgrandja
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose)
Milestone
5.0.0.M5

Comments

@rwinch
Copy link
Member

rwinch commented Jul 10, 2017 •
edited
Loading

Summary

Currently NimbusOAuth2UserService supports custom users, OIDC Users, and OAuth Users. It would be better if we could decouple this into 3 separate services and have a generic delegating OAuth2UserService. This simplifies the class, simplifies expanding other use cases, and ensures users can leverage only some of the functionality.

NOTE: Splitting up also allows JWT to be optional dependency if using something like GitHub which doesn't use JWT
@rwinch rwinch added the in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) label Jul 10, 2017
@rwinch rwinch added this to the 5.0.0.M3 milestone Jul 10, 2017
@jgrandja jgrandja modified the milestones: 5.0.0.M3, 5.0.0.M4 Jul 24, 2017
@jgrandja jgrandja mentioned this issue Aug 15, 2017
Closed
28 tasks
@rwinch rwinch modified the milestones: 5.0.0.M4, 5.0.0.M5 Sep 13, 2017
@jgrandja jgrandja self-assigned this Sep 25, 2017
@jgrandja jgrandja mentioned this issue Sep 28, 2017
Closed
thomasdarimont pushed a commit to thomasdarimont/spring-security that referenced this issue Apr 25, 2018
@jgrandja @thomasdarimont
Split up NimbusOAuth2UserService
69b6e3e 
Fixes spring-projectsgh-4447
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgrandja jgrandja

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose)
Projects
None yet
Milestone
5.0.0.M5
Development

No branches or pull requests
2 participants
@rwinch @jgrandja