Skip to content

Commit eca2b67

Browse files
committed
ClientRegistration supports 'baseUrl' uri variable
Fixes gh-4589
1 parent dec0bce commit eca2b67

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

oauth2/oauth2-client/src/main/java/org/springframework/security/oauth2/client/web/AuthorizationCodeRequestRedirectFilter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -160,14 +160,14 @@ private String expandRedirectUri(HttpServletRequest request, ClientRegistration
160160
uriVariables.put("contextPath", request.getContextPath());
161161
uriVariables.put("registrationId", clientRegistration.getRegistrationId());
162162

163-
String baseRedirectUrl = UriComponentsBuilder.newInstance()
163+
String baseUrl = UriComponentsBuilder.newInstance()
164164
.scheme(request.getScheme())
165165
.host(request.getServerName())
166166
.port(request.getServerPort())
167167
.path(request.getContextPath())
168168
.build()
169169
.toUriString();
170-
uriVariables.put("baseRedirectUrl", baseRedirectUrl);
170+
uriVariables.put("baseUrl", baseUrl);
171171

172172
return UriComponentsBuilder.fromUriString(clientRegistration.getRedirectUri())
173173
.buildAndExpand(uriVariables)

samples/boot/oauth2login/src/main/resources/META-INF/oauth2-clients-defaults.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ security:
55
google:
66
client-authentication-method: basic
77
authorization-grant-type: authorization_code
8-
redirect-uri: "{scheme}://{serverName}:{serverPort}{contextPath}/oauth2/authorize/code/{registrationId}"
8+
redirect-uri: "{baseUrl}/oauth2/authorize/code/{registrationId}"
99
scope: openid, profile, email, address, phone
1010
authorization-uri: "https://accounts.google.com/o/oauth2/v2/auth"
1111
token-uri: "https://www.googleapis.com/oauth2/v4/token"
@@ -16,7 +16,7 @@ security:
1616
github:
1717
client-authentication-method: basic
1818
authorization-grant-type: authorization_code
19-
redirect-uri: "{baseRedirectUrl}/oauth2/authorize/code/{registrationId}"
19+
redirect-uri: "{baseUrl}/oauth2/authorize/code/{registrationId}"
2020
scope: user
2121
authorization-uri: "https://github.com/login/oauth/authorize"
2222
token-uri: "https://github.com/login/oauth/access_token"

0 commit comments

Comments
 (0)