feat: Replace LinkedList with ArrayList

[janeklb]

Initialise the "batch of records" list container as an ArrayList rather than LinkedList.

Using a LinkedList has an impact on performance as outlined here #3764

(fixes #3764)

[artembilan]

We got a failed test with your change:

 SubBatchPerPartitionTests > withFilter() FAILED
    org.opentest4j.AssertionFailedError: 
    Expecting value to be true but was false
        at app//org.springframework.kafka.listener.SubBatchPerPartitionTests.withFilter(SubBatchPerPartitionTests.java:121)

And you indeed mentioned that in the issue.
WDYT?

[janeklb]

We got a failed test with your change:

 SubBatchPerPartitionTests > withFilter() FAILED
    org.opentest4j.AssertionFailedError: 
    Expecting value to be true but was false
        at app//org.springframework.kafka.listener.SubBatchPerPartitionTests.withFilter(SubBatchPerPartitionTests.java:121)

And you indeed mentioned that in the issue. WDYT?

Apologies -- I raised the PR too quickly. I assumed using Arrays.asList would have fixed the failing test (because List.of produces an immutable list and the failure seemed to be related to mutation..), but I only re-ran the tests locally after pushing this PR. Will investigate and let you know shortly.

[janeklb]

Turns out my comment here #3764 (comment) was totally wrong. I misunderstood the implementation of ArrayList#add(E element). Your suggestion @artembilan #3764 (comment) #3764 (comment) works perfect 👍🏻

[artembilan]

LGTM.
Will be merged (and back-ported) when all tests pass.

Thank you for your contribution!

[janeklb]

LGTM. Will be merged (and back-ported) when all tests pass.

Thank you for your contribution!

Wonderful, thank you for helping me getting over the line. When should I expect a new 3.3.x release?

[artembilan]

When should I expect a new 3.3.x release?

See our Release Calendar for March: https://spring.io/projects#release-calendar