GH-3741: Fix metric tag to show underlying exception type #3756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: spring-projects#3741 Issue: spring-projects#3741 When exceptions occur in Kafka listeners, the metrics currently show `ListenerExecutionFailedException` in both the `error` tag (when using observation) and `exception` tag (when using micrometer without observation), rather than the actual underlying exception. * Modify ListenerContainer to pass actual exception to failure metrics * Update MessagingMessageListenerAdapter to report cause to observation * Add MicrometerMetricsTests to verify both observation and non-observation metrics * Fix ObservationTests to verify correct error reporting in metrics This ensures metrics show the actual underlying exception while maintaining existing span behavior. Signed-off-by: Soby Chacko <[email protected]> **Auto-cherry-pick to `3.3.x` & `3.2.x`**
artembilan
requested changes
Feb 18, 2025
|
|
||
| /** | ||
| * @author Soby Chacko | ||
| * @since 3.3.3 |
There was a problem hiding this comment.
Suggested change
| * @since 3.3.3 | |
| * @since 3.2.7 |
| static class Config { | ||
|
|
||
| @Bean | ||
| KafkaAdmin admin(EmbeddedKafkaBroker broker) { |
There was a problem hiding this comment.
I wonder why do we need this bean?
| } | ||
|
|
||
| @Bean | ||
| SimpleTracer simpleTracer() { |
There was a problem hiding this comment.
Do we use this bean somewhere?
There was a problem hiding this comment.
sorry - copy error from the other test :)
|
Yeah... Let's see if we want to have this fix in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3741
Issue: #3741
When exceptions occur in Kafka listeners, the metrics currently show
ListenerExecutionFailedExceptionin both theerrortag (when using observation) andexceptiontag (when using micrometer without observation), rather than the actual underlying exception.This ensures metrics show the actual underlying exception while maintaining existing span behavior.
Signed-off-by: Soby Chacko [email protected]
Auto-cherry-pick to
3.3.x&3.2.x