Skip to content

Commit 43bc67a

Browse files
committed
Fix Race In Test
- use `BlockingQueue` instead of `ArrayList`.
1 parent 3850a01 commit 43bc67a

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

spring-kafka/src/test/java/org/springframework/kafka/listener/ConcurrentMessageListenerContainerTests.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,10 @@
3333
import java.util.Map;
3434
import java.util.Properties;
3535
import java.util.Set;
36+
import java.util.concurrent.BlockingQueue;
3637
import java.util.concurrent.ConcurrentSkipListSet;
3738
import java.util.concurrent.CountDownLatch;
39+
import java.util.concurrent.LinkedBlockingQueue;
3840
import java.util.concurrent.TimeUnit;
3941
import java.util.concurrent.atomic.AtomicBoolean;
4042
import java.util.concurrent.atomic.AtomicReference;
@@ -149,7 +151,7 @@ protected Consumer<Integer, String> createKafkaConsumer(String groupId, String c
149151
new ConcurrentMessageListenerContainer<>(cf, containerProps);
150152
container.setConcurrency(2);
151153
container.setBeanName("testAuto");
152-
List<KafkaEvent> events = new ArrayList<>();
154+
BlockingQueue<KafkaEvent> events = new LinkedBlockingQueue<>();
153155
CountDownLatch stopLatch = new CountDownLatch(4);
154156
container.setApplicationEventPublisher(e -> {
155157
events.add((KafkaEvent) e);

0 commit comments

Comments
 (0)