Apply Junit5BestPractices in spring-integration-mail #9946
Conversation
|
discussion: #9947 |
There was a problem hiding this comment.
Would you mind to include some details into commit message saying "what" and "why".
Because what I see so far is just removal of public word from those test methods.
While it is convenient to not use it and less words to ready, I find this as silly best practice.
And discussing it takes more time then just leave it as is.
Such a change just don't bring any benefits.
We definitely can accept your change and merge it since you have already dedicated some effort to bring this into life.
But, please, consider in the future to not waste your time for such a pointless change.
Unless that was an automatic pass and we indeed can go ahead and apply it everywhere in the project.
This is not my first discussion about applying OpenRewrite and I think that applying its rules is OK to satisfy community expectations. But that has to be a reasonable amount of the effort.
Thanks for understanding.
|
Totally agreed with you, I will dig more into this further, from effort and benefit perspective. (actually I didn't waste much time on it, it an auto process, maybe 5mins?, I didn't auto rewrite for all modules is considering too many files changes would be hard for reviewing, if your internal team can do that, that will be great) thank you again for nice feedback. |
1. remove public keyword for test methods 2. remove test prefix for test methods Signed-off-by: Ma,Jiandong <[email protected]>
use open-rewrite Junit5BestPractices recipe to rewrite test for spring-integration-mail module