Skip to content

GH-3027: Rotator enhancements 5.1.x #3033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dturanski
Copy link
Contributor

Backport for #3027

  • Move MessageSource specific logic to 'onRotation()'
  • Remove assertions
  • Make getCurrent() public

@dturanski dturanski requested a review from artembilan August 15, 2019 18:40
Copy link
Member

@artembilan artembilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@garyrussell ?

@garyrussell
Copy link
Contributor

I already said LGTM.

@artembilan
Copy link
Member

Great! Let's wait for green Travis report and merge!

@dturanski , feel free to provide similar JavaDoc and method body fix on master.
Thanks

@artembilan artembilan merged commit baf2b8d into spring-projects:5.1.x Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants