Skip to content

Fix issue with lists not being converted to domain objects #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

koenpunt
Copy link
Contributor

@koenpunt koenpunt commented Sep 16, 2021

Because lists are assignable from lists, it didn't convert the objects in the list, which remained LinkedHashMaps.

By always passing lists to the converter this issue is solved.

Because lists are assignable from list, it didn't convert the objects in the list. By always passing lists to the converter this issue is solved.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 16, 2021
@bclozel
Copy link
Member

bclozel commented Sep 17, 2021

Thanks @koenpunt , but this has been taken care of in #122 as part of a larger rewrite.
Keep the feedback coming, we'll be happy to help you with more contributions!

@bclozel bclozel closed this Sep 17, 2021
@bclozel bclozel added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 17, 2021
@koenpunt koenpunt deleted the list-argument-resolving branch September 17, 2021 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants