adding check if logger is in debug mode to avoid string concatenation of... #652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of the whole response object which might get quite large. At the moment object concatenation is done always although it's only required in debug mode
|
Good catch - thanks for raising this! Committed to master as part of a general revision of WebAsyncManager; to be backported to 4.0.x and 3.2.x as well. |
|
Thanks! 在 2014-09-26 19:40:47，"Juergen Hoeller" [email protected] 写道： Closed #652. — |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding check if logger is in debug mode to avoid string concatenation of the whole response object which might get quite large.
At the moment object concatenation is done always although it's only required in debug mode.
I've been tracking CPU usage of my application and multiple times have I seen in thread dump that concatenation taking a lot of CPU where I actually don't need it (as I'm not running in debug mode)