Skip to content

Restore TomcatHeadersAdapter.clear() behavior #34092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Restore TomcatHeadersAdapter.clear() behavior #34092

wants to merge 1 commit into from

Conversation

izeye
Copy link
Contributor

@izeye izeye commented Dec 15, 2024 •
edited by sbrannen
Loading

This PR fixes a regression introduced in TomcatHeadersAdapter.clear() in conjunction with #33916.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Dec 15, 2024
@sbrannen sbrannen added in: web Issues in web modules (web, webmvc, webflux, websocket) type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Dec 15, 2024
@sbrannen sbrannen self-assigned this Dec 15, 2024
@sbrannen sbrannen added this to the 7.0.0-M1 milestone Dec 15, 2024
@sbrannen sbrannen changed the title Fix TomcatHeadersAdapter.clear() Restore TomcatHeadersAdapter.clear() behavior Dec 15, 2024
@sbrannen sbrannen closed this in c8009dc Dec 15, 2024
sbrannen added a commit that referenced this pull request Dec 15, 2024
@sbrannen
Restore TomcatHeadersAdapter.clear() behavior
8a8df90 
This commit restores the original behavior of the clear() method in
TomcatHeadersAdapter by delegating to
org.apache.tomcat.util.http.MimeHeaders.recycle(), which aligns with
the memory efficiency goals documented in the class-level Javadoc for
MimeHeaders.

See gh-33916
Closes gh-34092
@sbrannen
Copy link
Member

This has been merged into main in c8009dc.

Thanks!

p.s. I revised the contribution in 8a8df90 in order to restore the original behavior.

@izeye izeye deleted the clear branch December 15, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sbrannen sbrannen

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: task A general task
Projects
None yet
Milestone
7.0.0-M1
Development

Successfully merging this pull request may close these issues.
3 participants
@izeye @sbrannen @spring-projects-issues