Skip to content

Auto-detect Jackson XML and JAXB in RestClient #34001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

xehpuk
Copy link

@xehpuk xehpuk commented Dec 2, 2024

Closes gh-34000

@pivotal-cla
Copy link

@xehpuk Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@xehpuk Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Dec 2, 2024
@bclozel
Copy link
Member

bclozel commented Dec 2, 2024

I don't think this is an oversight. Requesting XML using HTTP clients is a bit out of fashion so we don't intend to add this by default.

@bclozel bclozel closed this Dec 2, 2024
@bclozel bclozel added in: web Issues in web modules (web, webmvc, webflux, websocket) status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Dec 2, 2024
@xehpuk
Copy link
Author

xehpuk commented Dec 2, 2024

Isn't adding Jackson XML to the classpath opting-in? Not having it is already the default.

@bclozel
Copy link
Member

bclozel commented Dec 2, 2024

Automatic classpath detection and general support are different things. You can already configure XML support in RestClient quite easily. Whether we automatically configure the converter in RestClient and the ordering matters. Community members have recently complained that this mechanism is too agressive and that libraries can sometimes be on your classpath against your will (see #32384). For more opinionated preferences, maybe we should defer to Spring Boot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RestClient should auto-detect MappingJackson2XmlHttpMessageConverter
4 participants