Skip to content

fix the kotlin suspend function validation issure 23499. #29840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

cjdxhjj
Copy link

@cjdxhjj cjdxhjj commented Jan 18, 2023

the issure is #29793

@pivotal-cla
Copy link

@cjdxhjj Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jan 18, 2023
@pivotal-cla
Copy link

@cjdxhjj Thank you for signing the Contributor License Agreement!

@sdeleuze
Copy link
Contributor

Thanks for this PR, I don't think I would fix it this way, but this allowed me to achieve I think a similar outcome just by removing KotlinReflectionParameterNameDiscoverer usage in LocalValidatorFactoryBean, see #23499 (comment). So please try my change instead and provide your feedback as a comment in #23499. Since we will likely use another implementation of the same idea, I will close this PR unmerged.

@sdeleuze sdeleuze closed this Jan 18, 2023
@sdeleuze sdeleuze added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply theme: kotlin An issue related to Kotlin support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants