Skip to content

getHandlerInternal support multiple calls and avoid repeated lookupHandlerMethod #29544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

getHandlerInternal support multiple calls and avoid repeated lookupHandlerMethod #29544

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a128453
Update RequestMappingInfoHandlerMapping.java
ShijunDeng Nov 22, 2022
08c153e
Update RequestMappingInfoHandlerMapping.java
ShijunDeng Nov 22, 2022
32da320
Update RequestMappingInfoHandlerMapping.java
ShijunDeng Nov 26, 2022
3d5125d
Update RequestMappingInfoHandlerMapping.java
ShijunDeng Nov 26, 2022
951e288
Update RequestMappingInfoHandlerMapping.java
ShijunDeng Nov 26, 2022
e6ad117
Update RequestMappingInfoHandlerMapping.java
ShijunDeng Nov 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...java/org/springframework/web/reactive/result/method/RequestMappingInfoHandlerMapping.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,10 @@ protected Comparator<RequestMappingInfo> getMappingComparator(final ServerWebExc

@Override
public Mono<HandlerMethod> getHandlerInternal(ServerWebExchange exchange) {
Object handler = exchange.getAttributes().get(HandlerMapping.BEST_MATCHING_HANDLER_ATTRIBUTE);
if (handler instanceof HandlerMethod) {
return Mono.just((HandlerMethod) handler);
}
exchange.getAttributes().remove(HandlerMapping.PRODUCIBLE_MEDIA_TYPES_ATTRIBUTE);
return super.getHandlerInternal(exchange)
.doOnTerminate(() -> ProducesRequestCondition.clearMediaTypesAttribute(exchange));
Expand Down Expand Up @@ -136,7 +140,7 @@ protected void handleMatch(RequestMappingInfo info, HandlerMethod handlerMethod,
matrixVariables = result.getMatrixVariables();
}

exchange.getAttributes().put(BEST_MATCHING_HANDLER_ATTRIBUTE, handlerMethod);
exchange.getAttributes().putIfAbsent(BEST_MATCHING_HANDLER_ATTRIBUTE, handlerMethod);
exchange.getAttributes().put(BEST_MATCHING_PATTERN_ATTRIBUTE, bestPattern);
exchange.getAttributes().put(URI_TEMPLATE_VARIABLES_ATTRIBUTE, uriVariables);
exchange.getAttributes().put(MATRIX_VARIABLES_ATTRIBUTE, matrixVariables);
Expand Down