Skip to content

Make getters public in NamedParameterJdbcTemplate and ParsedSql #23371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

garydgregory
Copy link

Make getters public in two public classes.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jul 26, 2019
@sbrannen
Copy link
Member

Can you please provide the rationale and a concrete use case for the proposed changes?

@sbrannen sbrannen added status: waiting-for-feedback We need additional information before we can continue in: data Issues in data modules (jdbc, orm, oxm, tx) labels Jul 26, 2019
@sbrannen sbrannen changed the title Make getters public in two public classes. Make getters public in NamedParameterJdbcTemplate and ParsedSql Jul 26, 2019
@garydgregory
Copy link
Author

Hi @sbrannen ,

I work on a proprietary product that uses Spring Batch as an ETL component in a suite. This ETL component has a custom copy of org.springframework.batch.item.database.JdbcBatchItemWriter as well as a subclass. This does all sorts of magic specific to our product. This code needs access to various bits and pieces of the Spring object tree which is currently achieved via reflection (nasty) which would be better served via public and protected APIs (nice.) I hope this helps clarify things.

Thank you,
Gary

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Jul 26, 2019
@quaff
Copy link
Contributor

quaff commented Jul 31, 2019

+1 #20759

@snicoll
Copy link
Member

snicoll commented Sep 26, 2022

Thanks for the PR but we're not keen to expose APIs like that, see #23766 (comment)

@snicoll snicoll closed this Sep 26, 2022
@snicoll snicoll added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged or decided on status: feedback-provided Feedback has been provided labels Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants