Provide functionality similar to Spring Boot's BeanTypeRegistry #23341
Conversation
Update `ListableBeanFactory` and `BeanFactoryUtils` to add the missing `getBeanNamesForType` methods that accept a `ResolvableType` rather than a `Class`. This completes the work started in 778a019. Closes spring-projectsgh-23335
Update the logic in `AbstractBeanFactory` so that caches from merged bean definitions remain whenever possible. Prior to this commit, all merged bean definitions would be completely removed after bean post processing in case a processor changed the bean type. It's fairly unlikely these days that the bean type will actually change, so instead we now compare a subset of the old cached properties against the newly created definition. Only if key properties have changed do we now discard the older cached values. Closes spring-projectsgh-23336
Add an additional cache to the `RootBeanDefinition` to save recalculating the result of `isFactoryBean`. Closes spring-projectsgh-23337
Update the `FactoryBean` type prediction logic (primarily in the `DefaultListableBeanFactory`) so that generic type information is considered when calling `getBeanNamesForType` on a non-frozen configuration. Calling `getBeanNamesForType` with `allowEagerInit` disabled will now detect `FactoryBean` variants as long as generic type information is available in either the class or the factory method return type. Closes spring-projectsgh-23338
Update `getTypeForFactoryBean` detection so that a bean definition attribute can be used to supply the result. This commit allows projects such as Spring Data to provide the result that would be supplied by `getObjectType` early so that we don't need to initialize the `FactoryBean` unnecessarily. Closes spring-projectsgh-23338
Update code that's often called so that zero length array results use a single shared static constant, rather than a new instance for each call. Closes spring-projectsgh-23340
spring-projects-issues
added
the
status: waiting-for-triage
|
@philwebb Your changes look good. In context to spring-projects/spring-boot#16615, I have one (probably silly) question: Is there a way to ask the BeanFactory for a Bean Definition's type without forcing the initialization of that bean? Essentially a I am likely missing something obvious. I could change the Predicate to accept a |
|
@tkvangorder I'm not sure there is such an API yet. I've raised #23374 to look into it after this one is merged. |
jhoeller
added
in: core
Initial attempt at fixing the issues raised from #23056. Since these changes are quite core, careful review is required.