Skip to content

Cleaned up Javadoc in DispatcherServlet #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

bijukunjummen
Copy link
Contributor

This is a minor change to the javadoc of DispatcherServlet to bring it in line with the changes with Spring 3.1.x+ - there were references to DefaultAnnotationHandlerMapping and AnnotationMethodHandlerAdapter which I have now changed to RequestMappingHandlerMapping and RequestMappingHandlerAdapter respectively

I have signed and agree to the terms of the SpringSource Individual
Contributor License Agreement.

@ghost ghost assigned rstoyanchev Jan 7, 2013
@cbeams
Copy link
Contributor

cbeams commented Jan 7, 2013

Thanks, Biju! @rstoyanchev perhaps you'd like to do the merge here.

@rstoyanchev
Copy link
Contributor

Thanks for the update. However, DefaultAnnotationhandlerMapping and AnnotationMethodHandlerAdapter are still used by default (see DispatcherServlet.properties). RequestMappingHandlerMapping and RequestMappingHandlerAdapter are used with the MVC namespace.

BTW in 3.2, DefaultAnnotationhandlerMapping and AnnotationMethodHandlerAdapter were deprecated so we may switch the defaults in the next release.

@bijukunjummen
Copy link
Contributor Author

Oh, okay, I misunderstood the meaning of default - I thought it is the handlerMappings, handlerAdapters that get created when mvc:annotation-driven/ is used, not the handlerMappings, handlerAdapters created when nothing but DispatcherServlet is defined.

Let me go ahead and close this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants