Trace and Span IDs are no longer propagated RequestBodyAdvice beans #33128
Assignees
Labels
in: web
Issues in web modules (web, webmvc, webflux, websocket)
theme: observability
An issue related to observability and tracing
type: backport
An issue that is a backport of another issue to a maintenance branch
type: regression
A bug that is also a regression
Milestone
Comments
github-actions
bot
added
theme: observability
bclozel
added a commit
that referenced
this issue
Jul 1, 2024
Prior to this commit, the fix for gh-32730 disabled the involvment of the osbervation filter for async dispatches. Instead of relying on ASYNC dispatches to close the observation for async requests, this is now using an async listener instead: async dispatches are not guaranteed to happen once the async request is handled. This change caused another side-effect: because async dispatches are not considered anymore by this filter, the observation scope is not reinstated for async dispatches. For example, `ResponseBodyAdvice` implementations do not have the observation scope opened during their execution. This commit re-enables async dispatches for this filter, but ensures that observations are not closed during such dispatches as this will be done by the async listener. Fixes gh-33128
|
Fixed via a352d88 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Backport of gh-33091
The text was updated successfully, but these errors were encountered: