-
Notifications
You must be signed in to change notification settings - Fork 38.5k
Determine why transferTo tests fail for Undertow #25310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Instead of simply returning prematurely and allowing the tests to be marked as SUCCESS, this commit uses a failed assumption to abort the the trasferTo tests for Undertow, resulting in the parameterized test invocation properly being marked as ABORTED. See spring-projectsgh-25310
I'm working on a Jetty Core integration that is similar to undertow in that it is a fully asynchronous integration without servlets. We are also failing However, if we copy the bytebuffers as we create the DataBuffer wrappers around the jetty buffer abstraction. We see no leaks of either DataBuffer references, nor the underlying jetty RetainableByteBuffer. Thus our current best theory is that this test is accessing the databuffer after it has been released. So maybe this is a bad test?? How is undertow failing this test? |
Strangely enough we are also failing |
With the introduction of the
DefaultMultipartParser
, two tests started failing when running against Undertow:org.springframework.web.reactive.function.MultipartIntegrationTests#transferTo
andorg.springframework.web.reactive.result.method.annotation.MultipartIntegrationTests#transferTo
.As temporary workaround the tests were disabled for 5.3 M1, but this needs to be resolved by M2.
The text was updated successfully, but these errors were encountered: