Skip to content

DefaultWebClientBuilder default ClientHttpConnector by classpath #23491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rwinch opened this issue Aug 20, 2019 · 0 comments
Closed

DefaultWebClientBuilder default ClientHttpConnector by classpath #23491

rwinch opened this issue Aug 20, 2019 · 0 comments
Labels
status: superseded An issue that has been superseded by another

Comments

@rwinch
Copy link
Member

rwinch commented Aug 20, 2019

It would be nice if DefaultWebClientBuilder#initExchangeFunction was smart enough to select the default ClientHttpConnector based upon classpath. This would make it so that it worked with both Netty and Jetty based ClientHttpConnector without needing to explicitly configure the ClientHttpConnector.
@rwinch rwinch mentioned this issue Aug 20, 2019
Closed
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Aug 20, 2019
@rwinch rwinch changed the title DefaultWebClientBuilder initialize ClientHttpConnector by classpath DefaultWebClientBuilder default ClientHttpConnector by classpath Aug 20, 2019
rwinch added a commit to rwinch/spring-framework that referenced this issue Aug 20, 2019
@rwinch
DefaultWebClientBuilder defaults using classpath
ea35d4e 
Previously DefaultWebClientBuilder always defaulted the ClientHttpConnector
with ReactorClientHttpConnector. This worked fine if reactor was used.
However, it would break if the user was trying to leverage Jetty.

This commit defaults to use Reactory Netty HttpClient if it is present. If
it is not present it then Jetty's HttpClient  is used if present.

Closes spring-projectsgh-23491
@rwinch rwinch mentioned this issue Aug 20, 2019
Closed
@rstoyanchev rstoyanchev added status: superseded An issue that has been superseded by another and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Aug 20, 2019
rstoyanchev pushed a commit that referenced this issue Aug 21, 2019
@rwinch @rstoyanchev
DefaultWebClientBuilder defaults using classpath
ca3a0b1 
Previously DefaultWebClientBuilder always defaulted the ClientHttpConnector
with ReactorClientHttpConnector. This worked fine if reactor was used.
However, it would break if the user was trying to leverage Jetty.

This commit defaults to use Reactory Netty HttpClient if it is present. If
it is not present it then Jetty's HttpClient  is used if present.

Closes gh-23491
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: superseded An issue that has been superseded by another
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Detect ClientHttpConnector to use by checking classpath rwinch/spring-framework
3 participants
@rwinch @rstoyanchev @spring-projects-issues