Skip to content

Minor documentation issue for Validators #22945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Anticom opened this issue May 11, 2019 · 1 comment
Closed

Minor documentation issue for Validators #22945

Anticom opened this issue May 11, 2019 · 1 comment
Labels
status: duplicate A duplicate of another issue

Comments

@Anticom
Copy link

Anticom commented May 11, 2019

Affects: \5.0.0.M1

Hi, in the code snippet for the CustomerValidator a quote went missing

Actual:

//...
    public CustomerValidator(Validator addressValidator) {
        // ...
        if (!addressValidator.supports(Address.class)) {
            throw new IllegalArgumentException("The supplied [Validator] must " +
                support the validation of [Address] instances.");
        }
        // ...
    }
//...

Expected:

//...
    public CustomerValidator(Validator addressValidator) {
        // ...
        if (!addressValidator.supports(Address.class)) {
            throw new IllegalArgumentException("The supplied [Validator] must " +
                "support the validation of [Address] instances.");
        }
        // ...
    }
//...

Hope this is the right issue tracker to submit it to. If there's a repo for the documentation, please let me know and I can attach a PR to the issue next time 😄


@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label May 11, 2019
@snicoll
Copy link
Member

snicoll commented May 12, 2019

@Anticom thanks for reporting but the first milestone of Spring 5.0 is quite old so I'd check first that a more recent release has a fix.

Turns out this was fixed in 5.0.0.M2 (see #1181)

@snicoll snicoll closed this as completed May 12, 2019
@snicoll snicoll added status: duplicate A duplicate of another issue and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels May 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: duplicate A duplicate of another issue
Projects
None yet
Development

No branches or pull requests

3 participants