HibernateJpaDialect: Default to MySQL55Dialect based on InnoDB [SPR-16468]

[spring-projects-issues]

Mike Eltsufin opened SPR-16468 and commented

MySQL5Dialect set currently as default is based on the MyISAM storage engine, which is not recommended.
MySQL 5.5 has been out since 2010. So, it's pretty safe to go with it as the default dialect.

Related to: spring-attic/spring-cloud-gcp#392.

See PR: #1660

---

Affects: 5.0.3

Reference URL: https://stackoverflow.com/questions/1459265/hibernate-create-mysql-innodb-tables-instead-of-myisam

Issue Links:

• Add SAP HANA to common JPA database platforms [SPR-16460] #21005 Add SAP HANA to common JPA database platforms

Referenced from: pull request #1660

1 votes, 4 watchers

[spring-projects-issues]

Juergen Hoeller commented

I'm not concerned about a MySQL 5.5 default from a version availability perspective. However, a change from MyISAM to InnoDB could be perceived as too radical. In practice, I expect most people to explicitly declare their dialect already since they won't be happy with the default... but there might still be some innocent usage of the MyISAM default in some places.

Nevertheless: Stéphane Nicoll, Phil Webb, if you feel that this is worth doing for Boot 2.0 GA, I'm happy to give it a try in 5.0.4 (and ask people affected to explicitly declare the old dialect if they care).

[spring-projects-issues]

Juergen Hoeller commented

It looks like MySQL55Dialect is only available in Hibernate ORM 5.2.9 and later. Since we support any Hibernate 5.x version at this point (even the default 5.0.x and 5.1.x versions included in JBoss EAP 7 and older WildFly releases), I'm afraid we can only raise the default dialect level in a Spring Framework generation that raises the Hibernate ORM baseline.

Along the same lines, we should also upgrade to Informix10Dialect at the same time.

[snicoll]

Duplicate of #22326