Add SAP HANA to common JPA database platforms [SPR-16460]

[spring-projects-issues]

Jonathan Bregler opened SPR-16460 and commented

Currently it's not possible to specify HANA as the database using the

spring.jpa.database

property.

---

Affects: 5.0.3

Issue Links:

• Add database product name for SAP HANA [SPR-14261] #18833 Add database product name for SAP HANA
• HibernateJpaDialect: Default to MySQL55Dialect based on InnoDB [SPR-16468] #21013 HibernateJpaDialect: Default to MySQL55Dialect based on InnoDB
• Consistent incrementer arrangement for PostgreSQL, DB2 and SAP HANA [SPR-16558] #21101 Consistent incrementer arrangement for PostgreSQL, DB2 and SAP HANA

Referenced from: pull request #1661, and commits 504e276

1 votes, 3 watchers

[spring-projects-issues]

Jonathan Bregler commented

Hi Jürgen,

do you have an estimate when my pull request could get merged? I'm planning on making more contributions to other Spring projects, but those contributions depend on this change.

Thanks,
Jonathan

[spring-projects-issues]

[email protected] commented

PR seems to be #1661

[spring-projects-issues]

Juergen Hoeller commented

This looks like a great fit for our 5.1 timeline. We'll start 5.1 preparations in about a month, right after the 5.0.5 release.

[spring-projects-issues]

Juergen Hoeller commented

I've narrowed this JIRA ticket to the primary purpose of the report: SAP HANA as a common database platform in Spring's JpaVendorAdapter mechanism, with a wider overhaul planned for 5.1 there.

As for the two side improvements of the pull request - namely detecting all database product name variants and introducing a HanaSequenceMaxValueIncrementer -, I'm in the process of dealing with them as part of #21101 for 5.0.5 and 4.3.15 already.

[spring-projects-issues]

Juergen Hoeller commented

I've rolled this into master for 5.1 RC1 now, as a custom commit that completes the scope of your original submission.

A note on Hibernate: Is HANAColumnStoreDialect indeed the ideal default there? Wouldn't HANARowStoreDialect be a better match for common ORM access patterns?

[spring-projects-issues]

Jonathan Bregler commented

Thanks for merging the change.

HANAColumnStoreDialect is indeed the correct default. The SAP HANA column store is generally preferred over the row store as it offers more features as well as other advantages. The HANARowStoreDialect should only be used in special cases if there is a concrete application requirement that can't be fulfilled by the HANAColumnStoreDialect.