Skip to content

Support Publishers for multipart data in BodyInserters [SPR-16307] #20854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spring-projects-issues opened this issue Dec 17, 2017 · 3 comments
Closed
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Dec 17, 2017

Marc-Christian Schulze opened SPR-16307 and commented

In order to stream content into a MultipartRequest it would be nice to have support for Publisher, e.g.:

Publisher<ByteBuffer> publisher = ...

WebClient 
    .create(someUrl) 
    .post() 
    .uri(URI.create("/whatever")) 
    .body(BodyInserters.fromMultipartData("file", publisher))
    ...

Issue Links:

Referenced from: commits 283811b, 7035ee7, 6c3a645, f23612c

@spring-projects-issues
Copy link
Collaborator Author

Arjen Poutsma commented

Fixed in 7035ee7

@spring-projects-issues
Copy link
Collaborator Author

Arjen Poutsma commented

Reopening, as storing the ResolvableType in the HttpEntity might not be the best way to implement this.

@spring-projects-issues
Copy link
Collaborator Author

Arjen Poutsma commented

Fixed by moving the ResolvableType to a new HttpEntity subtype: 6c3a645

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants