Skip to content

Reduce access on user in SimpleBrokerMessageHandler.handleMessageInternal [SPR-16264] #20811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spring-projects-issues opened this issue Dec 5, 2017 · 2 comments
Closed

Reduce access on user in SimpleBrokerMessageHandler.handleMessageInternal [SPR-16264] #20811

spring-projects-issues opened this issue Dec 5, 2017 · 2 comments
Assignees
@jhoeller
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Milestone
5.0.3

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Dec 5, 2017 •
edited
Loading

Christoph Dreis opened SPR-16264 and commented

Hi,

similar to #20713 I found another improvement where unnecessary access to message headers is performed. This time in SimpleBrokerMessageHandler where we look for a user while this is only really needed for CONNECT/DISCONNECT messages. It's not as big as #20713, but I think nonetheless worthwhile.

The attached PR moves the access on the user header to only CONNECT/DISCONNECT messages in SimpleBrokerMessageHandler.

I'd appreciate if this PR gets accepted.

Cheers,
Christoph

Affects: 4.3.13

Referenced from: pull request #1614, and commits 0b77c88, f4e9fb5, bf88311

Backported to: 4.3.14
@spring-projects-issues
Copy link
Collaborator Author

Juergen Hoeller commented

Applied to master now; I'll backport it to 4.3.x ASAP.

@spring-projects-issues
Copy link
Collaborator Author

Christoph Dreis commented

Thanks, Jürgen.

@spring-projects-issues spring-projects-issues added status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement in: web Issues in web modules (web, webmvc, webflux, websocket) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 5.0.3 milestone Jan 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Projects
None yet
Milestone
5.0.3
Development

No branches or pull requests
2 participants
@jhoeller @spring-projects-issues