Skip to content

Reduce access on user in SimpleBrokerMessageHandler.handleMessageInternal [SPR-16264] #20811

@spring-projects-issues

Description

@spring-projects-issues

Christoph Dreis opened SPR-16264 and commented

Hi,

similar to #20713 I found another improvement where unnecessary access to message headers is performed. This time in SimpleBrokerMessageHandler where we look for a user while this is only really needed for CONNECT/DISCONNECT messages. It's not as big as #20713, but I think nonetheless worthwhile.

The attached PR moves the access on the user header to only CONNECT/DISCONNECT messages in SimpleBrokerMessageHandler.

I'd appreciate if this PR gets accepted.

Cheers,
Christoph


Affects: 4.3.13

Referenced from: pull request #1614, and commits 0b77c88, f4e9fb5, bf88311

Backported to: 4.3.14

Metadata

Metadata

Assignees

Labels

in: webIssues in web modules (web, webmvc, webflux, websocket)status: backportedAn issue that has been backported to maintenance branchestype: enhancementA general enhancement

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions