BeanPropertyRowMapper should use ConversionService for date-time support [SPR-13888]

[spring-projects-issues]

Radmila opened SPR-13888 and commented

Program is using org.springframework.jdbc.core.BeanPropertyRowMapper to map result set to the bean.
When mapping timestamp resultset column to the bean's java.time.LocalDateTime field, process fails with
org.springframework.jdbc.support.JdbcUtils getResultSetValue with error
IllegalStateException: Cannot convert value of type [java.sql.Timestamp] to required type [java.time.LocalDateTime] for property 'nameproperty': no matching editors or conversion strategy found.

Problem with spring 4.1.6.RELEASE. and JDK 1.8

---

Issue Links:

• BeanPropertyRowMapper should always call toLowerCase with US encoding [SPR-13216] #17807 BeanPropertyRowMapper should always call toLowerCase with US encoding
• BeanPropertyRowMapper should log if mapRow doesn't find a PropertyDescriptor [SPR-13323] #17908 BeanPropertyRowMapper should log if mapRow doesn't find a PropertyDescriptor
• BeanPropertyRowMapper should be able to convert SQL timestamp to java.time.LocalDate/LocalTime [SPR-14898] #19464 BeanPropertyRowMapper should be able to convert SQL timestamp to java.time.LocalDate/LocalTime
• Shared DefaultConversionService instance e.g. for BeanPropertyRowMapper [SPR-14948] #19515 Shared DefaultConversionService instance e.g. for BeanPropertyRowMapper
• Update JdbcUtils to improve enum support [SPR-14990] #19556 Update JdbcUtils to improve enum support

Referenced from: commits 7c96059

1 votes, 3 watchers

[spring-projects-issues]

Juergen Hoeller commented

The problem is not so much in JdbcUtils which simply returns what the JDBC driver gives us. We're trying JDBC 4.1's getObject(int, Class) with a java.time.LocalDateTime argument in this case, but if that call happens to fail against your JDBC driver, we'll just plain getObject(int) which usually returns a java.sql.Timestamp in such a case. I suppose that's your scenario.

However, arguably, BeanPropertyRowMapper should use its BeanWrapper preconfigured with a DefaultConversionService: Our date-time conversion capabilities are built-in there, so even if a java.sql.Timestamp comes along, we can convert it to a java.time.LocalDateTime bean property on our own. I'm looking at this as a default for Spring Framework 4.3.

For the time being, you could override the BeanPropertyRowMapper.initBeanWrapper method and call bw.setConversionService(new DefaultConversionService()); yourself.