OpenEntityManagerInViewInterceptor doesn't always close connections with WildFly 8 [SPR-12118]

[spring-projects-issues]

Phil Webb opened SPR-12118 and commented

This particular issue came up when testing a Spring Boot application but I eventually tracked it down to the use of OpenEntityManagerInViewInterceptor. It's very hard to replicate and I'm not totally sure if the issue is with Spring, WildFly or a combination of both.

I'll attach an issue project which will explain more.

---

Affects: 4.1 RC2

Issue Links:

• readOnly transaction doesn't work with JPA and Hibernate 4 [SPR-8959] #13599 readOnly transaction doesn't work with JPA and Hibernate 4

Referenced from: commits spring-projects/spring-boot@6ee18fb

[spring-projects-issues]

Phil Webb commented

See https://github.com/spring-projects/spring-framework-issues/tree/master/SPR-12118

[spring-projects-issues]

Phil Webb commented

This appears to be a regression, the sample doesn't fail with Spring 4.0.6

[spring-projects-issues]

Juergen Hoeller commented

This has been addressed through revised Connection reset logic, never kicking in for JTA transactions now. Apparently an accidental Connection.setReadOnly(false) call, despite that being the default state of a JDBC Connection, can cause side effects in a JTA scenario...

More importantly for the general case, this change also avoids Connection retrieval just for reset purposes.

Juergen