AnnotationConfigApplicationContext does not detect BeanFactoryPostProcessor [SPR-6455]

[spring-projects-issues]

Dave King opened SPR-6455 and commented

The documentation in several places says:

"Application contexts can auto-detect BeanFactoryPostProcessor beans in their bean definitions and apply them before any other beans get created. "

Thus @Bean BeanFactoryPostProcessor getSomeName(){ return new BeanFactoryPostProcessorImpl();} in a @Configuration class should cause the BeanFactoryPostProcessor run in the AnnotationConfigApplicationContext. Doesn't work. The callback method is never called. The bean is created, but only after other beans have been created.

This breaks the documented contract for an ApplicationContext.

---

Affects: 3.0 RC2

Reference URL: http://forum.springsource.org/showthread.php?t=81044

Issue Links:

• @Value does not work with AnnotationConfigApplicationContext [SPR-6611] #11277 @Value does not work with AnnotationConfigApplicationContext
• PropertyPlaceholder does not work for @ImportResource in JavaConfig [SPR-6645] #11311 PropertyPlaceholder does not work for @ImportResource in JavaConfig

Referenced from: commits 6b2b5c4, 8ab9da4

3 votes, 5 watchers

[spring-projects-issues]

Grzegorz Grzybek commented

Also there is problem with BeanFactoryPostprocessors registered in XML context included using @ImportResource annotation.
The problem is with an example in 3.11.3.2 chapter of reference doc:

@Configuration
@ImportResource("classpath:/com/acme/properties-config.xml")
public class AppConfig {
    private @Value("${jdbcProperties.url}") String url;
    private @Value("${jdbcProperties.username}") String username;
    private @Value("${jdbcProperties.password}") String password;

    public @Bean DataSource dataSource() {
        return new DriverManagerDataSource(url, username, password);
    }
}

does not work @ImportResource is processed by last call to {invokeBeanFactoryPostProcessors} in {org.springframework.context.support.AbstractApplicationContext.invokeBeanFactoryPostProcessors(ConfigurableListableBeanFactory)}, so to invoke bean factory postprocessors defined in XML included with @ImportResource, there is a need for one more {invokeBeanFactoryPostProcessors} call..

does this loop ever ends?

regards
Grzegorz Grzybek

[spring-projects-issues]

Juergen Hoeller commented

Fixed through introducing a BeanDefinitionRegistryPostProcessor which gets invoked against the BeanDefinitionRegistry - before BeanFactoryPostProcessors get retrieved and applied. Any bean definitions registered by a BeanDefinitionRegistryPostProcessor are eligible for being run as BeanFactoryPostProcessors in the next phase. ConfigurationClassPostProcessors takes advantage of exactly that benefit, processing @Bean method in the BeanDefinitionRegistryPostProcessor phase now.

Juergen