Use default visibility for test classes and methods in spring-core

See gh-23451

Author: sbrannen

spring-core/src/test/java/org/springframework/core/type/AnnotationTypeFilterTestsTypes.java renamed to spring-core/src/test/java/example/type/AnnotationTypeFilterTestsTypes.java

@@ -14,51 +14,52 @@
  * limitations under the License.
  */
 
-package org.springframework.core.type;
+package example.type;
 
 /**
  * We must use a standalone set of types to ensure that no one else is loading
- * them and interfering with {@link ClassloadingAssertions#assertClassNotLoaded(String)}.
+ * them and interfering with
+ * {@link org.springframework.core.type.ClassloadingAssertions#assertClassNotLoaded(String)}.
  *
  * @author Ramnivas Laddad
  * @author Juergen Hoeller
  * @author Oliver Gierke
  * @author Sam Brannen
- * @see AnnotationTypeFilterTests
+ * @see org.springframework.core.type.AnnotationTypeFilterTests
  */
-class AnnotationTypeFilterTestsTypes {
+public class AnnotationTypeFilterTestsTypes {
 
-	@AnnotationTypeFilterTests.InheritedAnnotation
-	private static class SomeComponent {
+	@InheritedAnnotation
+	public static class SomeComponent {
 	}
 
 
-	@AnnotationTypeFilterTests.InheritedAnnotation
-	private interface SomeComponentInterface {
+	@InheritedAnnotation
+	public interface SomeComponentInterface {
 	}
 
 
 	@SuppressWarnings("unused")
-	private static class SomeClassWithSomeComponentInterface implements Cloneable, SomeComponentInterface {
+	public static class SomeClassWithSomeComponentInterface implements Cloneable, SomeComponentInterface {
 	}
 
 
 	@SuppressWarnings("unused")
-	private static class SomeSubclassOfSomeComponent extends SomeComponent {
+	public static class SomeSubclassOfSomeComponent extends SomeComponent {
 	}
 
-	@AnnotationTypeFilterTests.NonInheritedAnnotation
-	private static class SomeClassMarkedWithNonInheritedAnnotation {
+	@NonInheritedAnnotation
+	public static class SomeClassMarkedWithNonInheritedAnnotation {
 	}
 
 
 	@SuppressWarnings("unused")
-	private static class SomeSubclassOfSomeClassMarkedWithNonInheritedAnnotation extends SomeClassMarkedWithNonInheritedAnnotation {
+	public static class SomeSubclassOfSomeClassMarkedWithNonInheritedAnnotation extends SomeClassMarkedWithNonInheritedAnnotation {
 	}
 
 
 	@SuppressWarnings("unused")
-	private static class SomeNonCandidateClass {
+	public static class SomeNonCandidateClass {
 	}
 
 }

spring-core/src/test/java/org/springframework/core/type/AspectJTypeFilterTestsTypes.java renamed to spring-core/src/test/java/example/type/AspectJTypeFilterTestsTypes.java

@@ -14,38 +14,39 @@
  * limitations under the License.
  */
 
-package org.springframework.core.type;
+package example.type;
 
 import org.springframework.stereotype.Component;
 
 /**
  * We must use a standalone set of types to ensure that no one else is loading
- * them and interfering with {@link ClassloadingAssertions#assertClassNotLoaded(String)}.
+ * them and interfering with
+ * {@link org.springframework.core.type.ClassloadingAssertions#assertClassNotLoaded(String)}.
  *
  * @author Ramnivas Laddad
  * @author Sam Brannen
- * @see AspectJTypeFilterTests
+ * @see org.springframework.core.type.AspectJTypeFilterTests
  */
 public class AspectJTypeFilterTestsTypes {
 
-	interface SomeInterface {
+	public interface SomeInterface {
 	}
 
-	static class SomeClass {
+	public static class SomeClass {
 	}
 
-	static class SomeClassExtendingSomeClass extends SomeClass {
+	public static class SomeClassExtendingSomeClass extends SomeClass {
 	}
 
-	static class SomeClassImplementingSomeInterface implements SomeInterface {
+	public static class SomeClassImplementingSomeInterface implements SomeInterface {
 	}
 
-	static class SomeClassExtendingSomeClassExtendingSomeClassAndImplementingSomeInterface
+	public static class SomeClassExtendingSomeClassExtendingSomeClassAndImplementingSomeInterface
 			extends SomeClassExtendingSomeClass implements SomeInterface {
 	}
 
 	@Component
-	static class SomeClassAnnotatedWithComponent {
+	public static class SomeClassAnnotatedWithComponent {
 	}
 
 }

spring-core/src/test/java/org/springframework/core/type/AssignableTypeFilterTestsTypes.java renamed to spring-core/src/test/java/example/type/AssignableTypeFilterTestsTypes.java

@@ -14,38 +14,39 @@
  * limitations under the License.
  */
 
-package org.springframework.core.type;
+package example.type;
 
 /**
  * We must use a standalone set of types to ensure that no one else is loading
- * them and interfering with {@link ClassloadingAssertions#assertClassNotLoaded(String)}.
+ * them and interfering with
+ * {@link org.springframework.core.type.ClassloadingAssertions#assertClassNotLoaded(String)}.
  *
  * @author Ramnivas Laddad
  * @author Juergen Hoeller
  * @author Sam Brannen
- * @see AssignableTypeFilterTests
+ * @see org.springframework.core.type.AssignableTypeFilterTests
  */
-class AssignableTypeFilterTestsTypes {
+public class AssignableTypeFilterTestsTypes {
 
-	static class TestNonInheritingClass {
+	public static class TestNonInheritingClass {
 	}
 
-	interface TestInterface {
+	public interface TestInterface {
 	}
 
-	static class TestInterfaceImpl implements TestInterface {
+	public static class TestInterfaceImpl implements TestInterface {
 	}
 
-	interface SomeDaoLikeInterface {
+	public interface SomeDaoLikeInterface {
 	}
 
-	static class SomeDaoLikeImpl extends SimpleJdbcDaoSupport implements SomeDaoLikeInterface {
+	public static class SomeDaoLikeImpl extends SimpleJdbcDaoSupport implements SomeDaoLikeInterface {
 	}
 
-	interface JdbcDaoSupport {
+	public interface JdbcDaoSupport {
 	}
 
-	static class SimpleJdbcDaoSupport implements JdbcDaoSupport {
+	public static class SimpleJdbcDaoSupport implements JdbcDaoSupport {
 	}
 
 }

spring-core/src/test/java/example/type/InheritedAnnotation.java

@@ -0,0 +1,26 @@
+/*
+ * Copyright 2002-2019 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package example.type;
+
+import java.lang.annotation.Inherited;
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+
+@Inherited
+@Retention(RetentionPolicy.RUNTIME)
+public @interface InheritedAnnotation {
+}

spring-core/src/test/java/example/type/NonInheritedAnnotation.java

@@ -0,0 +1,24 @@
+/*
+ * Copyright 2002-2019 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package example.type;
+
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+
+@Retention(RetentionPolicy.RUNTIME)
+public @interface NonInheritedAnnotation {
+}

spring-core/src/test/java/org/springframework/core/AttributeAccessorSupportTests.java

@@ -27,7 +27,7 @@
  * @author Sam Brannen
  * @since 2.0
  */
-public class AttributeAccessorSupportTests {
+class AttributeAccessorSupportTests {
 
 	private static final String NAME = "foo";
 
@@ -36,28 +36,28 @@ public class AttributeAccessorSupportTests {
 	private AttributeAccessor attributeAccessor = new SimpleAttributeAccessorSupport();
 
 	@Test
-	public void setAndGet() throws Exception {
+	void setAndGet() throws Exception {
 		this.attributeAccessor.setAttribute(NAME, VALUE);
 		assertThat(this.attributeAccessor.getAttribute(NAME)).isEqualTo(VALUE);
 	}
 
 	@Test
-	public void setAndHas() throws Exception {
+	void setAndHas() throws Exception {
 		assertThat(this.attributeAccessor.hasAttribute(NAME)).isFalse();
 		this.attributeAccessor.setAttribute(NAME, VALUE);
 		assertThat(this.attributeAccessor.hasAttribute(NAME)).isTrue();
 	}
 
 	@Test
-	public void remove() throws Exception {
+	void remove() throws Exception {
 		assertThat(this.attributeAccessor.hasAttribute(NAME)).isFalse();
 		this.attributeAccessor.setAttribute(NAME, VALUE);
 		assertThat(this.attributeAccessor.removeAttribute(NAME)).isEqualTo(VALUE);
 		assertThat(this.attributeAccessor.hasAttribute(NAME)).isFalse();
 	}
 
 	@Test
-	public void attributeNames() throws Exception {
+	void attributeNames() throws Exception {
 		this.attributeAccessor.setAttribute(NAME, VALUE);
 		this.attributeAccessor.setAttribute("abc", "123");
 		String[] attributeNames = this.attributeAccessor.attributeNames();