Fix construction of NullSafeComparator in nullsLow

Homlet · jhoeller · commit 80e7819d6f25 · 2018-10-05T13:20:28.000+02:00
Previously, both nullsLow(Comparator&lt;T&gt;) and
nullsHigh(Comparator&lt;T&gt;) returned a
NullSafeComparator which treated nulls as being
high. This commit corrects this typo.
diff --git a/spring-core/src/main/java/org/springframework/util/comparator/Comparators.java b/spring-core/src/main/java/org/springframework/util/comparator/Comparators.java
@@ -52,7 +52,7 @@ public static <T> Comparator<T> nullsLow() {
 	 * @see NullSafeComparator#NullSafeComparator(boolean)
 	 */
 	public static <T> Comparator<T> nullsLow(Comparator<T> comparator) {
-		return new NullSafeComparator<>(comparator, false);
+		return new NullSafeComparator<>(comparator, true);
 	}
 
 	/**

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ public static <T> Comparator<T> nullsLow() {`
`52`	`52`	`* @see NullSafeComparator#NullSafeComparator(boolean)`
`53`	`53`	`*/`
`54`	`54`	`public static <T> Comparator<T> nullsLow(Comparator<T> comparator) {`
`55`		`- return new NullSafeComparator<>(comparator, false);`
	`55`	`+ return new NullSafeComparator<>(comparator, true);`
`56`	`56`	`}`
`57`	`57`
`58`	`58`	`/**`