Skip to content

Commit 548126d

Browse files
committed
Consistently pass param info to ServerWebInputException
Issue: SPR-17232
1 parent 7e9857a commit 548126d

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed

spring-webflux/src/main/java/org/springframework/web/reactive/result/method/annotation/AbstractMessageReaderArgumentResolver.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -218,8 +218,9 @@ private Throwable handleReadError(MethodParameter parameter, Throwable ex) {
218218
new ServerWebInputException("Failed to read HTTP message", parameter, ex) : ex);
219219
}
220220

221-
private ServerWebInputException handleMissingBody(MethodParameter param) {
222-
return new ServerWebInputException("Request body is missing: " + param.getExecutable().toGenericString());
221+
private ServerWebInputException handleMissingBody(MethodParameter parameter) {
222+
String paramInfo = parameter.getExecutable().toGenericString();
223+
return new ServerWebInputException("Request body is missing: " + paramInfo, parameter);
223224
}
224225

225226
/**

spring-webflux/src/main/java/org/springframework/web/reactive/result/method/annotation/MatrixVariableMethodArgumentResolver.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -120,8 +120,9 @@ else if (paramValues.size() == 1) {
120120

121121
@Override
122122
protected void handleMissingValue(String name, MethodParameter parameter) throws ServerWebInputException {
123-
throw new ServerWebInputException("Missing matrix variable '" + name +
124-
"' for method parameter of type " + parameter.getNestedParameterType().getSimpleName());
123+
String paramInfo = parameter.getNestedParameterType().getSimpleName();
124+
throw new ServerWebInputException("Missing matrix variable '" + name + "' " +
125+
"for method parameter of type " + paramInfo, parameter);
125126
}
126127

127128

spring-webflux/src/main/java/org/springframework/web/reactive/result/method/annotation/RequestHeaderMethodArgumentResolver.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,8 +90,8 @@ protected Object resolveNamedValue(String name, MethodParameter parameter, Serve
9090
@Override
9191
protected void handleMissingValue(String name, MethodParameter parameter) {
9292
String type = parameter.getNestedParameterType().getSimpleName();
93-
throw new ServerWebInputException("Missing request header '" + name +
94-
"' for method parameter of type " + type);
93+
throw new ServerWebInputException("Missing request header '" + name + "' " +
94+
"for method parameter of type " + type, parameter);
9595
}
9696

9797

0 commit comments

Comments
 (0)