ASM-generated class names get interned for better memory allocation

jhoeller · jhoeller · commit 3a29daac45d9 · 2016-11-08T17:38:57.000+01:00
Issue: SPR-14886
diff --git a/spring-core/src/main/java/org/springframework/asm/ClassReader.java b/spring-core/src/main/java/org/springframework/asm/ClassReader.java
@@ -2464,7 +2464,8 @@ public String readClass(final int index, final char[] buf) {
         // computes the start index of the CONSTANT_Class item in b
         // and reads the CONSTANT_Utf8 item designated by
         // the first two bytes of this CONSTANT_Class item
-        return readUTF8(items[readUnsignedShort(index)], buf);
+        String name = readUTF8(items[readUnsignedShort(index)], buf);
+        return (name != null ? name.intern() : null);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -2464,7 +2464,8 @@ public String readClass(final int index, final char[] buf) {`
`2464`	`2464`	`// computes the start index of the CONSTANT_Class item in b`
`2465`	`2465`	`// and reads the CONSTANT_Utf8 item designated by`
`2466`	`2466`	`// the first two bytes of this CONSTANT_Class item`
`2467`		`- return readUTF8(items[readUnsignedShort(index)], buf);`
	`2467`	`+ String name = readUTF8(items[readUnsignedShort(index)], buf);`
	`2468`	`+ return (name != null ? name.intern() : null);`
`2468`	`2469`	`}`
`2469`	`2470`
`2470`	`2471`	`/**`