Allow query methods get multiple parameters from Map or JavaBean and add them to the SqlParameterSource. #1564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…add them to the SqlParameterSource.
spring-projects-issues
added
the
status: waiting-for-triage
mp911de
added
status: declined
|
Thanks for your suggestion. We have general support for SpEL to bind parameters from input objects. You variant bears the risk of name clashing if table or join identifiers match the argument name. As we have already a flexible mechanism, we do not intend adding another one. You might want to elaborate on why SpEL doesn't seem sufficient for your case and what we can improve there. |
|
Sure, I created #1566 to update our documentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I submitted this PR to allow query methods get multiple parameters from Map or JavaBean and add them to the SqlParameterSource.
Since the Parameter does not provide a method to determine whether the parameter is declared with the given annotation type, I have to do it using reflection. I think it would be better if the Parameter provided more methods, such as "hasParameterAnnotation", etc.