Handle Docker Hub rate limiting using proxy server for Testcontainers. #1516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mp911de
reviewed
May 17, 2023
ci/test.sh
Outdated
|
|
||
| echo "Hard linking ProxyImageNameSubstitutor into JDBC and R2DBC..." | ||
| pushd spring-data-jdbc/src/test/java/org/springframework/data | ||
| ln -f ../../../../../../../spring-data-relational/src/test/java/org/springframework/data/ProxyImageNameSubstitutor.java . |
There was a problem hiding this comment.
How about copying the Java file? Hard linking seems unusual
mp911de
reviewed
May 17, 2023
| @@ -0,0 +1,83 @@ | |||
| /* | |||
| * Copyright 2015-2023 the original author or authors. | |||
There was a problem hiding this comment.
Nit: We start with the year of introduction, so Copyright would be 2023 only.
When run on CI servers, leverage an internal proxy service using Testcontainers ability to plugin a custom ImageNameSubstitor. See #1516
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feel free to comment.