Skip to content

Commit e010fab

Browse files
committed
Switch to Testcontainers Oracle Free.
Timeout increased from the default because that cause problems on CI. Brought SD JDBC now uses `ojdbc11` as R2DBC. Closes #1665 Original pull request #1668
1 parent 126b848 commit e010fab

File tree

4 files changed

+13
-7
lines changed

4 files changed

+13
-7
lines changed

spring-data-jdbc/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,7 @@
208208

209209
<dependency>
210210
<groupId>com.oracle.database.jdbc</groupId>
211-
<artifactId>ojdbc8</artifactId>
211+
<artifactId>ojdbc11</artifactId>
212212
<version>${oracle.version}</version>
213213
<scope>test</scope>
214214
</dependency>
@@ -251,7 +251,7 @@
251251

252252
<dependency>
253253
<groupId>org.testcontainers</groupId>
254-
<artifactId>oracle-xe</artifactId>
254+
<artifactId>oracle-free</artifactId>
255255
<scope>test</scope>
256256
</dependency>
257257

spring-data-jdbc/src/test/java/org/springframework/data/jdbc/testing/OracleDataSourceConfiguration.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,8 @@
2424
import org.springframework.jdbc.core.JdbcTemplate;
2525
import org.springframework.jdbc.datasource.DriverManagerDataSource;
2626
import org.springframework.jdbc.datasource.init.ResourceDatabasePopulator;
27-
import org.testcontainers.containers.OracleContainer;
27+
import org.testcontainers.oracle.OracleContainer;
28+
import org.testcontainers.utility.DockerImageName;
2829

2930
/**
3031
* {@link DataSource} setup for Oracle Database XE. Starts a docker container with an Oracle database.
@@ -50,7 +51,10 @@ protected DataSource createDataSource() {
5051
if (ORACLE_CONTAINER == null) {
5152

5253
LOG.info("Oracle starting...");
53-
OracleContainer container = new OracleContainer("gvenzl/oracle-xe:21.3.0-slim").withReuse(true);
54+
DockerImageName dockerImageName = DockerImageName.parse("gvenzl/oracle-free:23.3-slim");
55+
OracleContainer container = new OracleContainer(dockerImageName) //
56+
.withStartupTimeoutSeconds(200) //
57+
.withReuse(true);
5458
container.start();
5559
LOG.info("Oracle started");
5660

spring-data-r2dbc/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -310,7 +310,7 @@
310310

311311
<dependency>
312312
<groupId>org.testcontainers</groupId>
313-
<artifactId>oracle-xe</artifactId>
313+
<artifactId>oracle-free</artifactId>
314314
<scope>test</scope>
315315
</dependency>
316316

spring-data-r2dbc/src/test/java/org/springframework/data/r2dbc/testing/OracleTestSupport.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
import org.springframework.jdbc.core.JdbcTemplate;
3030
import org.springframework.jdbc.datasource.DriverManagerDataSource;
3131
import org.springframework.util.ClassUtils;
32-
import org.testcontainers.containers.OracleContainer;
32+
import org.testcontainers.oracle.OracleContainer;
3333

3434
/**
3535
* Utility class for testing against Oracle.
@@ -128,7 +128,9 @@ private static ExternalDatabase testContainer() {
128128
if (testContainerDatabase == null) {
129129

130130
try {
131-
OracleContainer container = new OracleContainer("gvenzl/oracle-xe:21.3.0-slim").withReuse(true);
131+
OracleContainer container = new OracleContainer("23.3-slim") //
132+
.withReuse(true) //
133+
.withStartupTimeoutSeconds(200); // the default of 60s isn't sufficient
132134
container.start();
133135

134136
testContainerDatabase = ProvidedDatabase.builder(container) //

0 commit comments

Comments
 (0)