-
Notifications
You must be signed in to change notification settings - Fork 364
Closed
Labels
status: waiting-for-triageAn issue we've not yet triagedAn issue we've not yet triaged
Description
Hi all (and @schauder),
This is a follow-on ticket from the discussions in #1528.
This Wednesday, Atomic Jar introduced a new Oracle Free module, which means that these lines:
Lines 58 to 62 in 42e786c
DockerImageName dockerImageName = DockerImageName.parse("gvenzl/oracle-free:23-slim") | |
.asCompatibleSubstituteFor("gvenzl/oracle-xe"); | |
OracleContainer container = new OracleContainer(dockerImageName) | |
.withDatabaseName("freepdb2") | |
.withReuse(true); |
can now be further simplified to:
var oracle = new OracleContainer("gvenzl/oracle-free:23-slim");
The following dependency is required:
<dependency>
<groupId>org.testcontainers</groupId>
<artifactId>oracle-free</artifactId>
<version>1.19.2</version>
<scope>test</scope>
</dependency>
Looking at the current code in OracleDataSourceConfiguration, I think the line withDatabase('freepdb2')
can also be removed. I think we added that because the default database names between oracle-xe and oracle-free TC modules are incompatible.
Removing that line means no new database XEPDB2
will be created at container startup which will further improve overall startup time.
Thanks,
fazlizekiqi
Metadata
Metadata
Assignees
Labels
status: waiting-for-triageAn issue we've not yet triagedAn issue we've not yet triaged