Skip to content

Simplify logic in RedisMessageListenerContainer and supporting classes #2663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Simplify logic in RedisMessageListenerContainer and supporting classes #2663

wants to merge 2 commits into from

Conversation

jxblum
Copy link
Contributor

@jxblum jxblum commented Aug 5, 2023

See #2662

@jxblum jxblum added the in: core Issues in core support label Aug 5, 2023
mp911de pushed a commit that referenced this pull request Aug 8, 2023
@jxblum @mp911de
Simplify logic in RedisMessageListenerContainer and supporting clas…
979fb6a 
…ses.

Closes #2662
Original pull request: #2663
mp911de added a commit that referenced this pull request Aug 8, 2023
@mp911de
Polishing.
6207a4f 
Replace topic label with assertion message. Reorder methods to align with Spring style.

See #2662
Original pull request: #2663
mp911de pushed a commit that referenced this pull request Aug 8, 2023
@jxblum @mp911de
Simplify logic in RedisMessageListenerContainer and supporting clas…
1ddfd4d 
…ses.

Closes #2662
Original pull request: #2663
mp911de added a commit that referenced this pull request Aug 8, 2023
@mp911de
Polishing.
49abd4e 
Replace topic label with assertion message. Reorder methods to align with Spring style.

See #2662
Original pull request: #2663
@mp911de
Copy link
Member

mp911de commented Aug 8, 2023

That was a good excercise, our code looks much clean now. That's merged, polished, and backported now.

@mp911de mp911de closed this Aug 8, 2023
@mp911de mp911de deleted the issue/2662 branch August 8, 2023 08:32
@mp911de mp911de added this to the 3.1.3 (2023.0.3) milestone Aug 8, 2023
@mp911de mp911de added the type: task A general task label Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mp911de mp911de Awaiting requested review from mp911de

@christophstrobl christophstrobl Awaiting requested review from christophstrobl

Assignees
No one assigned
Labels
in: core Issues in core support type: task A general task
Projects
None yet
Milestone
3.1.3 (2023.0.3)
Development

Successfully merging this pull request may close these issues.
2 participants
@jxblum @mp911de