Reset JedisConnectionFactory's destroyed flag when initializing bean

[Jiabao-Sun]

Reset JedisConnectionFactory's destroyed flag when initializing bean to prevent configuration hot upgrade issue.

Closes #2553

[Jiabao-Sun]

Hi @mp911de,
Could you help review it when you have time?

[mp911de]

We should revisit initialization in the scope of #2503

[jxblum]

@Jiabao-Sun - I agree with @mp911de here. This needs to be considered carefully, and will likely and necessarily be tied to the Spring containers lifecycle management capabilities in support of our CRaC efforts.

I also don't necessarily think or agree that allowing the JedisConnectionFactory bean to be reused after it has already been destroyed is necessarily the correct thing to do, in any case. After all, this assertion has been in place for sometime (used before acquiring connections, for instance) and while there is not a good documented reason for it, it is not seemingly arbitrary either.

Additionally, whatever we do with the Jedis based connection support should be consistently applied to the Lettuce connection support as well.

While this may look safe on the surface that is Spring Data (Redis), you must also consider what occurs, or state that is held in the drivers.

Unfortunately, I would need to think on and test this with several arrangements as well as different contexts (e.g. Spring Boot application), to determine whether this would even be safe to do in a majority of the cases. There is a good/strong reason why the core Spring Framework team rejected this ticket of mine many moons ago, which is similar in concept.