Skip to content

Reinstate starting RedisConnectionFactory through afterPropertiesSet for smooth upgrade path #2635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
christophstrobl opened this issue Jul 11, 2023 · 0 comments
Closed

Reinstate starting RedisConnectionFactory through afterPropertiesSet for smooth upgrade path #2635

christophstrobl opened this issue Jul 11, 2023 · 0 comments
Assignees
@christophstrobl
Labels
type: task A general task
Milestone
3.2 M1 (2023.1.0)

Comments

@christophstrobl
Copy link
Member

Switching form InitializingBean to a SmartLifecycle can cause issues for users depending on the current behaviour expecting the connection to be avaliable in afterPropertiesSet().

We should restore the previous behaviour to allow a smooth upgrade.

Related to: #2503
@christophstrobl christophstrobl added the type: task A general task label Jul 11, 2023
@christophstrobl christophstrobl self-assigned this Jul 11, 2023
@christophstrobl christophstrobl mentioned this issue Jul 11, 2023
Closed
@mp911de mp911de changed the title Startup RedisConnectionFactory in afterProperties set for smooth upgrade path. Reinstate starting RedisConnectionFactory through afterPropertiesSet for smooth upgrade path Jul 12, 2023
@mp911de mp911de added this to the 3.2 M1 (2023.1.0) milestone Jul 12, 2023
mp911de added a commit that referenced this issue Jul 12, 2023
@mp911de
Polishing.
9fe32d5 
Refine documentation about auto-startup. Set phase to zero to be in the middle between min and max.

See #2635
Original pull request: #2636
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@christophstrobl christophstrobl

Labels
type: task A general task
Projects
None yet
Milestone
3.2 M1 (2023.1.0)
2 participants
@mp911de @christophstrobl