Skip to content

DATAGRAPH-1290 - Add case insensitive order support for custom queries #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

ihordz
Copy link
Contributor

@ihordz ihordz commented Feb 13, 2020

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our JIRA.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

Copy link
Collaborator

@michael-simons michael-simons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR again! Thanks a lot.

@ihordz
Copy link
Contributor Author

ihordz commented Feb 14, 2020

@michael-simons
I've pushed requested changes.
Thank you for review.

@michael-simons
Copy link
Collaborator

This is now on master as 1ec70c4 and on 5.2.x as 0bcf9f2. On 5.2.x I rewrote the tests to use Junit 4 asserts, I didn't want to have mixed styles in the class, but that's an oversight on my side.

Your PRs are adding nice value, thank you, @ihordz .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants